Create Gray Glacier spec #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Beiko <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
=======================================
Coverage 77.82% 77.82%
=======================================
Files 333 333
Lines 19243 19243
=======================================
Hits 14976 14976
Misses 4267 4267
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
garyschulte
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
@daniellehrner and I spot checked these numbers and they appear correct. We will incorporate these into besu's gray glacier fork PR, and will update this comment with our calculated fork id.
12 tasks
yperbasis
approved these changes
Jun 14, 2022
This was referenced Jun 14, 2022
timbeiko
commented
Jun 14, 2022
LukaszRozmej
approved these changes
Jun 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification for the Gray Glacier network upgrade.
Rationale for the block offset chosen in EIP-5133 is available here. Calculations used to choose the block height are available here.
Given the speed of the process relative to usual, I would like to get a +1 from each EL client team before merging, cc: @tkstanczak, @garyschulte, @MariusVanDerWijden, @yperbasis. I will also leave this PR open until 15:00 UTC on Wednesday, June 15.