Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make puppeth play nice with domainless setups #15472

Closed
karalabe opened this issue Nov 13, 2017 · 4 comments
Closed

Make puppeth play nice with domainless setups #15472

karalabe opened this issue Nov 13, 2017 · 4 comments

Comments

@karalabe
Copy link
Member

Originally Puppeth was implemented so it can run web services both on raw ports on domain-less machines, as well as using port sharing behind reverse proxies and domains. Since we mostly used Puppeth in house for Rinkeby only, the domain-less mode of operation got broken without anyone noticing.

This issue is here to verify which functionality works still correctly and which got broken for domain-less setups and to patch them up. Note, this issue should only be started when #15390 is merged since that's a huge pending change.

@corpetty
Copy link

For what its worth:

Deploying to remote servers using user@ip for each server setup works for:

  • Ethstats
  • Bootnode
  • Sealnode
  • Faucet

Not Dashboard

Because I've only tested the current 1.7.3 version (not Devcon demo), it is hard to say if those changes broke or fixed some of the issues I currently have.

I also deploy each instance on separate ports.

@owocki
Copy link

owocki commented Dec 13, 2017

hey @karalabe -- 👋 hi there.. kevin from gitcoin. im considering putting a bounty on this issue (or the other help wanted issues on this repo) to help you all get some fresh interest on them. any objection? are there specific github issues that would make good test bounties? ill bring the budget, you just tell me what you want.

@corpetty
Copy link

Port sharing also doesn't work with domain-less deployments. I'll be playing around on a homenetwork of servers and VMs this month. I'll have more info on what doesn't work as time continues.

@stale
Copy link

stale bot commented Feb 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this as completed Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants