cmd/puppeth: new version as presented at devcon3 #15390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
force-pushed
the
puppeth-devcon3
branch
from
c20260e to
c750fad
Compare
karalabe
force-pushed
the
puppeth-devcon3
branch
from
c750fad to
b065648
Compare
karalabe
force-pushed
the
puppeth-devcon3
branch
from
b065648 to
79a46be
Compare
karalabe
force-pushed
the
puppeth-devcon3
branch
from
79a46be to
b169a30
Compare
gballet
reviewed
Nov 21, 2017
| ) | ||
|
|
||
| // explorerDockerfile is the Dockerfile required to run a block explorer. | ||
| var explorerDockerfile = ` |
There was a problem hiding this comment.
I see that you have a lot of these files embedded into go files. How about using something like Ego ? https://github.com/benbjohnson/ego
There was a problem hiding this comment.
I did consider using external file templates and perhaps embedding them with go generate and go-bindata. But truth be told these are fairly small files, so it's less of a hassle to just keep them embedded directly and have a single place to edit and debug them.
cmd/puppeth/module_node.go
Outdated
| // String implements the stringer interface. | ||
| func (info *nodeInfos) String() string { | ||
| discv5 := "" | ||
| // Report converts the typed struct into a plain string->string map, cotnaining |
There was a problem hiding this comment.
Good catch, fixed all occurrences.
cmd/puppeth/wizard_faucet.go
Outdated
| @@ -46,9 +47,10 @@ func (w *wizard) deployFaucet() { | |||
| minutes: 1440, | |||
| tiers: 3, | |||
| } | |||
| existed = false | |||
There was a problem hiding this comment.
so basically
existed := err == nil
There was a problem hiding this comment.
Yup, much cleaner, fixed all occurrences.
|
@gballet Thanks for the review! PTAL :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideal to have before merging:
faucetsource without needing an external repo (puppeth/go-ethereum).