Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth_getLogs needs to perform an indexed search #1895

Closed
ethernomad opened this issue Oct 11, 2015 · 1 comment
Closed

eth_getLogs needs to perform an indexed search #1895

ethernomad opened this issue Oct 11, 2015 · 1 comment

Comments

@ethernomad
Copy link
Contributor

eth_getLogs is too slow to be usable. If the address and topics were indexed it could be very fast.
@obscuren
Copy link
Contributor

No, indexing addresses and topics would require too much disk space eventually.

Improvement can be viewed in #1899 which speed things up by roughly 97%

@obscuren obscuren mentioned this issue Oct 12, 2015
Merged
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue Nov 1, 2023
@msmania
core/bloombits: fix deadlock when matcher session hits an error (ethe…
35b21ca 
…reum#1895)

When MatcherSession encounters an error, it attempts to close the session.
Closing waits for all goroutines to finish, including the 'distributor'.
However, the distributor will not exit until all requests have returned.

This patch fixes the issue by delivering the (empty) result to the distributor
before calling Close().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ethernomad @obscuren