Update the unclean shutdown marker every 5 minutes

[ligi]

I had a unclean shutdown less than a day ago and got this warning afterwards:

WARN [03-26|10:10:29.944] Unclean shutdown detected booted=2021-03-17T13:16:42+0000 age=1w1d20h

As it would be better to have the "age=" part closer to the shutdown @holiman suggested to update the marker like every 5 minutes

[David-C-Lee]

To clarify, you would like the "age=" to be precise, down to the minute?
PrettyAge() prints the age with precision of three units:

go-ethereum/les/client.go

Line 195 in 0c70b83

"age", common.PrettyAge(t))

Therefore, as far as I understand, an unclean shutdown that happened < one week ago will display the days, hours, and minutes. An unclean shutdown that happened > one month ago will only display months, weeks, and days.

To solve your issue, we need to use something other than PrettyAge().

If I am misunderstanding anything, please correct me, as I am brand new to the codebase.

[MariusVanDerWijden]

No @David-C-Lee the problem is, that we set the unclean-shutdown marker on startup. If the node crashes two weeks after startup, the age that is printed is the old startup age. It would be better to write the unclean-shutdown time every five minutes, thus we could see better when a node crashed

[prb22]

The reason it posts the startup time is because the crash doesn't last the entire time it takes to reboot. It only recognizes the last clean shutdown.

[Meegada-Mahesh]

Hi, can i work on it ?? last comment by @MariusVanDerWijden , i will take that as requirement for this feature

[MariusVanDerWijden]

Sure @Meegada-Mahesh, just send a PR when your done and I'll take a look

[Meegada-Mahesh]

/assign

[BitBaseBit]

Hey, @MariusVanDerWijden I've submitted a PR at #22974 that fixes this.

[jayboy-mabushi]

@Meegada-Mahesh I am getting unclean shutdown error and it is not pulling any new data. How can I resolve this?