Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uncle and block transaction count should accept "latest", "pending" and "earliest" as parameters #654

Closed
frozeman opened this issue Apr 7, 2015 · 4 comments
Closed

uncle and block transaction count should accept "latest", "pending" and "earliest" as parameters #654

frozeman opened this issue Apr 7, 2015 · 4 comments
Labels
area:rpc
Milestone
Frontier

Comments

@frozeman
Copy link
Contributor

frozeman commented Apr 7, 2015

Marek implemented the possibility for "latest" (last minded block), "pending" (pending) and "earliest" (genisis block) for the following RPC methods:

  • eth_getUncleCountByBlockNumber
  • eth_getUncleCountByBlockHash
  • eth_getBlockTransactionCountByHash
  • eth_getBlockTransactionCountByNumber

He sadly didn't put this as for debate, but integrated it already into ethereum.js as well and c++.
It makes sense to check for example for the number of pending transactions.

So i guess it makes sense if we integrate this behaviour as well.

I already add tests for it in the rpc-tests.
@frozeman frozeman added the RPC label Apr 7, 2015
@obscuren
Copy link
Contributor

obscuren commented Apr 7, 2015

This should be fixed on develop now

@tgerring tgerring mentioned this issue Apr 7, 2015
Closed
@tgerring
Copy link
Contributor

tgerring commented Apr 7, 2015

These are implemented for "ByNumber"

"ByHash" should not accept non-hash arguments

@obscuren
Copy link
Contributor

obscuren commented Apr 7, 2015

@frozeman retest and close accordingly

@obscuren obscuren added this to the Frontier milestone Apr 7, 2015
@tgerring
Copy link
Contributor

tgerring commented Apr 8, 2015

@frozeman Can this issue be closed?

ngtuna added a commit to ngtuna/tomochain that referenced this issue Aug 29, 2019
@ngtuna
Merge pull request ethereum#654 from thanhnguyennguyen/tomox-testing-…
0d2ff29 
…script

Update Tomox testing script
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022
@kobigurk
Attempts to fix the liner problem (ethereum#654)
fb8b6b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rpc
Projects
None yet
Milestone
Frontier
Development

No branches or pull requests
4 participants
@adamschmideg @frozeman @tgerring @obscuren