accounts/abi: handle events and redo unpack #14743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
VoR0220
commented
Jul 3, 2017
VoR0220
commented
- Enables unpacking of events using a common interface to methods
- Redoes unpack into modular pieces and functions
- Merge this after accounts/abi: Types redo #14735
fjl
force-pushed
the
handleEventsAndRedoUnpack
branch
from
cfe48fc to
1c6f875
Compare
fjl
changed the title
This was referenced Sep 10, 2017
|
Seems like there's a big chunk missing on the bind side to make this work. What would be needed to get this merged @fjl ? |
|
Any news on this? |
|
@fjl the last change allows for unpacking events/methods output into slices/arrays. |
|
what's holding up merging this besides the one bind test? |
Signed-off-by: RJ Catalano <[email protected]>
Signed-off-by: RJ Catalano <[email protected]>
Signed-off-by: RJ Catalano <[email protected]>
…edo abi Signed-off-by: RJ Catalano <[email protected]>
Signed-off-by: RJ Catalano <[email protected]>
Signed-off-by: RJ Catalano <[email protected]>
Signed-off-by: RJ Catalano <[email protected]>
No other read* function checks the length, so don't do it in readBool.
bas-vk
force-pushed
the
handleEventsAndRedoUnpack
branch
from
571786f to
b07ad26
Compare
|
Now rebased against latest master. @VoR0220 all tests should pass. |
|
My understanding was that the ability to pull values out of an interface was being deprecated in favor of a move to structs, is that not the case anymore? |
fjl
approved these changes
Oct 17, 2017
vincentserpoul
pushed a commit
to vincentserpoul/go-ethereum
that referenced
this pull request
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.