Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto, crypto/secp256k1: add CompressPubkey #15626

Merged
merged 8 commits into from
Dec 15, 2017

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Dec 7, 2017

No description provided.

@fjl fjl requested a review from holiman December 7, 2017 15:15
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw, it looks good to me. It wouldn't hurt with a few more testcases though, it seems like there's only one testcase, and that one decompresses a key and that's it (?)

@fjl
Copy link
Contributor Author

fjl commented Dec 8, 2017

@holiman PTAL

@fjl fjl merged commit c6069a6 into ethereum:master Dec 15, 2017
@karalabe karalabe added this to the 1.8.0 milestone Dec 15, 2017
gyn7561 added a commit to gyn7561/go-ethereum that referenced this pull request Dec 18, 2017
crypto, crypto/secp256k1: add CompressPubkey (ethereum#15626)
b00ris pushed a commit to b00ris/go-ethereum that referenced this pull request Jan 19, 2018
This adds the inverse to DecompressPubkey and improves a few minor
details in crypto/secp256k1.
mariameda pushed a commit to NiluPlatform/go-nilu that referenced this pull request Aug 23, 2018
This adds the inverse to DecompressPubkey and improves a few minor
details in crypto/secp256k1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants