whisper: sym encryption message padding includes salt #15631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluk256
reviewed
Dec 9, 2017
whisper/whisperv6/message.go
Outdated
| @@ -124,6 +124,8 @@ func (msg *sentMessage) appendPadding(params *MessageParams) error { | |||
| rawSize := len(params.Payload) + 1 | |||
| if params.Src != nil { | |||
| rawSize += signatureLength | |||
| } else { | |||
| rawSize += AESNonceLength | |||
There was a problem hiding this comment.
this is true only for symmetric encryption
There was a problem hiding this comment.
If Src is nil, then it's using symmetric encryption
There was a problem hiding this comment.
Src is used to identify the source of the message, i.e. for digital signature. Dst is used for asymmetrc encryption. And KeySym is used for symmetric encryption. So, you can change line 127 like this:
} else if params.KeySym != nil {
There was a problem hiding this comment.
Well then it's very confusing. Then both sym and asym should be able to sign their messages. So it should be if and not else if
gballet
force-pushed
the
whisper-v6-sym-padding
branch
from
e8b755a to
3f8f954
Compare
gluk256
approved these changes
Dec 10, 2017
fjl
approved these changes
Dec 11, 2017
b00ris
pushed a commit
to b00ris/go-ethereum
that referenced
this pull request
Jan 19, 2018
Now that the AES salt has been moved to the payload, padding must be adjusted to hide it, lest an attacker guesses that the packet uses symmetric encryption.
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
Now that the AES salt has been moved to the payload, padding must be adjusted to hide it, lest an attacker guesses that the packet uses symmetric encryption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the AES salt has been moved to the payload, padding must be adjusted to hide it, lest an attacker guesses that the packet uses symmetric encryption.