Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/ethkey: fix formatting, review nits #15807

Merged
merged 3 commits into from
Jan 16, 2018
Merged

cmd/ethkey: fix formatting, review nits #15807

merged 3 commits into from
Jan 16, 2018

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Jan 4, 2018

This PR:

  • Adds a --msgfile option to read the message to sign from a file
    instead of command line argument.
  • Adds a unit test for signing subcommands.
  • Removes some weird whitespace in the code.

fjl added 2 commits January 2, 2018 12:33
@fjl
internal/cmdtest: trim newline at beginning of regular expression
da45ea3
@fjl
cmd/ethkey: fix formatting, review nits
5a5eb44 
This commit:

- Adds a --msgfile option to read the message to sign from a file
  instead of command line argument.
- Adds a unit test for signing subcommands.
- Removes some weird whitespace in the code.
@fjl fjl requested a review from holiman January 4, 2018 11:56
holiman
holiman approved these changes Jan 16, 2018
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl
Copy link
Contributor Author

fjl commented Jan 16, 2018

go vet issue resolved, waiting for CI.

@fjl fjl merged commit f08cd94 into ethereum:master Jan 16, 2018
@karalabe karalabe added this to the 1.8.0 milestone Jan 16, 2018
@5chdn 5chdn mentioned this pull request Jan 30, 2018
Merged
prestonvanloon pushed a commit to prestonvanloon/go-ethereum that referenced this pull request Apr 2, 2018
@fjl @prestonvanloon
cmd/ethkey: fix formatting, review nits (ethereum#15807)
c886514 
This commit:

- Adds a --msgfile option to read the message to sign from a file
  instead of command line argument.
- Adds a unit test for signing subcommands.
- Removes some weird whitespace in the code.
mariameda pushed a commit to NiluPlatform/go-nilu that referenced this pull request Aug 23, 2018
@fjl @mariameda
cmd/ethkey: fix formatting, review nits (ethereum#15807)
08b97ff 
This commit:

- Adds a --msgfile option to read the message to sign from a file
  instead of command line argument.
- Adds a unit test for signing subcommands.
- Removes some weird whitespace in the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fjl @holiman @karalabe