common/fdlimit: Move fdlimit files to separate package #15850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When go-ethereum is used as a library the calling program need to set the FD limit. This commit extract fdlimit files to a separate package so it can be used outside of go-ethereum.
fjl
requested changes
Jan 11, 2018
common/fdlimit/fdlimit_windows.go
Outdated
| // to the maximum hard-limit allowed by the OS. | ||
| func raiseFdLimit(max uint64) error { | ||
| func RaiseFdLimit(max uint64) error { |
There was a problem hiding this comment.
Please rename the functions so FdLimit doesn't appear in the name.
There was a problem hiding this comment.
@fjl thanks for the feedback. I tried to find better names than Raise, Get and GetMax but couldn't come up with something better.
Any suggestions?
There was a problem hiding this comment.
@ricardohsd You could use Current and Maximum. Then you would have:
fdlimit.Raise, fdlimit.Current and fdlimit.Maximum.
There was a problem hiding this comment.
@karalabe thanks!
karalabe
approved these changes
Jan 11, 2018
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
* common/fdlimit: Move fdlimit files to separate package When go-ethereum is used as a library the calling program need to set the FD limit. This commit extract fdlimit files to a separate package so it can be used outside of go-ethereum. * common/fdlimit: Remove FdLimit from functions signature * common/fdlimit: Rename fdlimit functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
go-ethereumis used as a library the calling program need to set the FD limit.This commit extract fdlimit files to a separate package so it can be used outside of
go-ethereum.#15833