p2p/discv5: fix removeTicketRef cached ticket removal #15995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
approved these changes
Jan 30, 2018
prestonvanloon
pushed a commit
to prestonvanloon/go-ethereum
that referenced
this pull request
Apr 2, 2018
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an infinite loop in the topic register mechanism at shutdown. #15946 intended to fix a scenario when nextTicketCached was returned while the belonging topic was already removed. The panic was avoided but removeTicketRef should also clear the cached ticket (so that it is not returned again) and this also did not happen when the topic was missing. This PR moves the cache clearing before the missing topic check.
If also sets the log level of "Removing tickets from unknown topic" to Trace because this is a normal and frequently happening scenario during shutdown and we should not regularly print warning messages because of it.