whisper: bloom filter refactoring #16046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
requested changes
Feb 9, 2018
whisper/whisperv6/peer.go
Outdated
| peer.bloomFilter = bloom | ||
| peer.fullNode = isFullNode(bloom) | ||
| if peer.fullNode { | ||
| if peer.bloomFilter == nil { |
There was a problem hiding this comment.
I see a problem here, because I see that you are initializing it to all 1s when you set it. That means that, at some point, there could be someone trying to read the bloom filter before someone has initialized it. So I believe there should be a getBloomFilter as well.
gballet
approved these changes
Feb 9, 2018
prestonvanloon
pushed a commit
to prestonvanloon/go-ethereum
that referenced
this pull request
Apr 2, 2018
* whisper: bloom filter refactoring * whisper: fixed full node
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
* whisper: bloom filter refactoring * whisper: fixed full node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.