core: ewasm support #16957

gballet · 2018-06-12T10:23:05Z

This PR implements eWASM contracts based on github.com/go-interpreter/wagon.

gballet · 2018-06-12T10:25:44Z

The EEI functions require access to the module's memory. This is handled by go-interpreter/wagon#59 which is currently heavily discussed.

GitCop · 2018-06-19T11:43:05Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: 478d9555e5201b755d47c1874bd694f1bcb24766
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

GitCop · 2018-06-19T15:40:17Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: 478d9555e5201b755d47c1874bd694f1bcb24766
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

GitCop · 2018-06-19T15:46:50Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: 478d9555e5201b755d47c1874bd694f1bcb24766
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

GitCop · 2018-06-20T09:54:38Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: 478d9555e5201b755d47c1874bd694f1bcb24766
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

GitCop · 2018-06-21T09:34:33Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: 478d9555e5201b755d47c1874bd694f1bcb24766
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

GitCop · 2018-06-21T09:35:13Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: 478d9555e5201b755d47c1874bd694f1bcb24766
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

GitCop · 2018-06-21T12:39:20Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: 478d9555e5201b755d47c1874bd694f1bcb24766
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

0zAND1z · 2018-06-29T20:19:06Z

Great work here @gballet ! Which milestone does this PR belong to? Is this close to merge & publish in the upcoming build?

GitCop · 2018-07-19T13:28:21Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: 478d9555e5201b755d47c1874bd694f1bcb24766
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

axic · 2018-07-25T14:42:22Z

cmd/ewasm/main.go

 			if err != nil {
 				return errors.New(fmt.Sprintf("Could not instantiate vm: %v", err))
 			}

+			// If the module doesn't have any start function, check if the
+			// exports specify a `main` function and if so, execute it.


Also if the module has a start function, that shouldn't be executed as per current "ECI rules".

axic · 2018-07-25T14:45:43Z

tests/ewasm_test.go

+	"github.com/ethereum/go-ethereum/core/vm"
+)
+
+func TestEWASMVM(t *testing.T) {


This should ignore every test apart from the stEWASMTests directory.

GitCop · 2018-07-27T16:48:19Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: fd83338e30b81bbc231970ccb3e523b7172d91f8
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

GitCop · 2018-07-30T10:39:13Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: fd83338e30b81bbc231970ccb3e523b7172d91f8
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

GitCop · 2018-08-03T10:14:41Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: 19c2211333369c242a46649cd684f20126d5a1e4
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

GitCop · 2018-08-06T09:36:02Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: 19c2211333369c242a46649cd684f20126d5a1e4
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

axic · 2018-08-06T09:42:20Z

core/vm/ewasm_linker.go

@@ -104,7 +104,7 @@ var eeiFunctionList = []string{

 // ModuleResolver matches all EEI functions to native go functions
 func ModuleResolver(interpreter *InterpreterEWASM, name string) (*wasm.Module, error) {
-	if name != "env" {
+	if name != "env" && name != "ethereum" {


env should not be accepted

@gballet please address this :)

GitCop · 2018-08-10T16:24:46Z

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

Commit: 19c2211333369c242a46649cd684f20126d5a1e4
Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

axic · 2018-08-20T16:35:37Z

core/vm/ewasm.go

+
+	// If the module doesn't have any start function, check if the
+	// exports specify a `main` function and if so, execute it.
+	if module.Start == nil {


So is exec.NewVM executing the start function?

Since this is disabled in ewasm, you could just leave out the if (perhaps replace it with a panic).

In any case you need to add support for executing system contracts, at least in the create case, so that incoming bytecode can be run through metering.

axic · 2018-08-20T16:43:02Z

core/vm/ewasm_linker.go

+	"log",
+	"getBlockNumber",
+	"getTxOrigin",
+	"return",


This has been renamed to finish.

Node is now able to synchronize with the testnet when passing geth the option: `--vm.ewasm="metering:true"`.

Non-passing tests still need to be discussed in ewasm/hera#457 and ewasm/hera#456

axic · 2018-11-23T22:27:33Z

core/vm/ewasm.go

+			panic(fmt.Sprintf("Error loading the metering contract: %v", err))
+		}
+		// TODO when the metering contract abides by that rule, check that it
+		// only exports "main" and "memory".


This was done on the latest release (testnet milestone1)

axic · 2018-11-23T22:31:36Z

core/vm/ewasm.go

+
+	if in.metering {
+		metered, _, err := sentinel(in, code)
+		if len(metered) < 5 || err != nil {


Please review this against what Hera does.

axic · 2018-11-23T22:39:40Z

core/vm/ewasm.go

+			}
+		}
+
+		if len(code) > 8 {


Please compare these 8 and 5 length checks against Hera.

Latrasis · 2019-06-10T08:28:07Z

Hi @gballet, quick question, what is the status of this PR? Is there an Issue for tracking this?

gballet · 2019-08-15T08:45:11Z

@Latrasis this PR is currently on hold, as there is currently no clear sign that there is a strong desire to deploy ewasm on the eth1 mainnet.

The PR works, it needs a couple optimizations but could be used on private networks. Right now, we don't want to merge it because that would force us to keep maintaining it when there is no guarantee it will ever be used. Therefore, it has been put on hold.

cmd/ewasm/main.go

stale · 2020-09-02T06:04:22Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Co-authored-by: Brandon van Houten <[email protected]>

codefromthecrypt · 2022-04-02T23:12:43Z

Hi, I noticed ewasm repos seem to be maintained, but wondered if maybe another reason this didn't proceed was that the wagon project was archived.

we are working on a go-native wasm implementation (only adds 1.5M to a go binary and zero OS deps, no CGO etc), but need to ensure the API is able to cover main use cases. We are also starting to get questions about CPU limiting and feels like ewasm folks may have some experience here.

If someone could volunteer to have a look, that would be great. If that helps resurrection of ewasm (and that's a desired thing) all the better. otherwise, forgive the intrusion! https://github.com/tetratelabs/wazero

gballet requested review from holiman and karalabe as code owners June 12, 2018 10:23

gballet force-pushed the add-ewasm branch from f88e2ee to b795be8 Compare June 12, 2018 16:22

gballet force-pushed the add-ewasm branch from 3d1a7e1 to bcb16c2 Compare June 21, 2018 09:34

gballet force-pushed the add-ewasm branch from bcb16c2 to 43b3b89 Compare June 21, 2018 09:35

This was referenced Jun 21, 2018

Geth support ewasm/testnet#15

Closed

core/vm: support for various interpreters #17093

Merged

axic reviewed Jul 25, 2018

View reviewed changes

sbinet mentioned this pull request Jul 26, 2018

wagon/wasm: use upstream ontio/ontology#567

Closed

gballet force-pushed the add-ewasm branch from aed68ba to f6d94c0 Compare July 27, 2018 16:48

gballet force-pushed the add-ewasm branch from a19fcfd to e6d42a2 Compare July 30, 2018 10:50

axic reviewed Aug 6, 2018

View reviewed changes

axic reviewed Aug 20, 2018

View reviewed changes

core/vm/ewasm_linker.go Outdated

"log",

"getBlockNumber",

"getTxOrigin",

"return",

Copy link

Member

axic Aug 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been renamed to finish.

gballet added 2 commits October 21, 2018 18:54

core/vm: fix metering

972931c

Node is now able to synchronize with the testnet when passing geth the option: `--vm.ewasm="metering:true"`.

core/vm: activate EWASM on the testnet

43b668a

gballet force-pushed the add-ewasm branch from 48d9447 to 43b668a Compare October 24, 2018 13:54

core/vm: Fix all fixable tests

ac29f81

Non-passing tests still need to be discussed in ewasm/hera#457 and ewasm/hera#456

axic reviewed Nov 23, 2018

View reviewed changes

core/vm/ewasm.go

}

}

if len(code) > 8 {

Copy link

Member

axic Nov 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please compare these 8 and 5 length checks against Hera.

gballet added 4 commits November 24, 2018 00:04

core/vm: cleanup

ccec71b

core vm: Revert calls when balance > 128bits

ac0f688

core/vm: fix post init metering

90f926c

core/vm: fix build

634755b

0zAND1z mentioned this pull request Dec 7, 2018

add C/C++ guide ewasm/testnet#134

Open

core/vm: two sigs were wrong

ec0d4d7

adamschmideg added the status:triage label May 30, 2019

adamschmideg removed the status:triage label Jun 13, 2019

adamschmideg added status:triage status:on-hold and removed status:triage labels Aug 15, 2019

gballet changed the title ~~WIP: ewasm support~~ core: ewasm support Aug 15, 2019

teranos reviewed Sep 1, 2019

View reviewed changes

cmd/ewasm/main.go Outdated Show resolved Hide resolved

stale bot added the status:inactive label Sep 2, 2020

Update cmd/ewasm/main.go

ac930e2

Co-authored-by: Brandon van Houten <[email protected]>

gballet requested a review from rjl493456442 as a code owner September 2, 2020 08:02

stale bot removed the status:inactive label Sep 2, 2020

s1na mentioned this pull request Jun 25, 2021

all: remove noop vm config flags #23111

Merged

gballet closed this Jun 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core: ewasm support #16957

core: ewasm support #16957

gballet commented Jun 12, 2018 •

edited

Loading

gballet commented Jun 12, 2018

GitCop commented Jun 19, 2018

GitCop commented Jun 19, 2018

GitCop commented Jun 19, 2018

GitCop commented Jun 20, 2018

GitCop commented Jun 21, 2018

GitCop commented Jun 21, 2018

GitCop commented Jun 21, 2018

0zAND1z commented Jun 29, 2018

GitCop commented Jul 19, 2018

axic Jul 25, 2018

axic Jul 25, 2018

GitCop commented Jul 27, 2018

GitCop commented Jul 30, 2018

GitCop commented Aug 3, 2018

GitCop commented Aug 6, 2018

axic Aug 6, 2018

axic Sep 17, 2018

GitCop commented Aug 10, 2018

axic Aug 20, 2018

axic Aug 20, 2018

axic Nov 23, 2018

axic Nov 23, 2018

axic Nov 23, 2018

Latrasis commented Jun 10, 2019

gballet commented Aug 15, 2019

stale bot commented Sep 2, 2020

codefromthecrypt commented Apr 2, 2022

core: ewasm support #16957

core: ewasm support #16957

Conversation

gballet commented Jun 12, 2018 • edited Loading

gballet commented Jun 12, 2018

GitCop commented Jun 19, 2018

GitCop commented Jun 19, 2018

GitCop commented Jun 19, 2018

GitCop commented Jun 20, 2018

GitCop commented Jun 21, 2018

GitCop commented Jun 21, 2018

GitCop commented Jun 21, 2018

0zAND1z commented Jun 29, 2018

GitCop commented Jul 19, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GitCop commented Jul 27, 2018

GitCop commented Jul 30, 2018

GitCop commented Aug 3, 2018

GitCop commented Aug 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GitCop commented Aug 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Latrasis commented Jun 10, 2019

gballet commented Aug 15, 2019

stale bot commented Sep 2, 2020

codefromthecrypt commented Apr 2, 2022

gballet commented Jun 12, 2018 •

edited

Loading