core/vm: tweak the --vm.ewasm= option format
#17895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
karalabe
reviewed
Oct 24, 2018
| @@ -43,7 +43,7 @@ type Config struct { | |||
| JumpTable [256]operation | |||
|
|
|||
| // Type of the EWASM interpreter | |||
| EWASMInterpreter string | |||
| EWASMInterpreter map[string]string | |||
There was a problem hiding this comment.
The interpreter config should remain a string. There's no point in expanding it in eth/backend. Just split it where you actually need it (in the EWASM's constructor inside core/vm).
|
Not gonna argue with a grumpy cat face, I'll close it right away ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wagon will also need to use the
--vm.ewasm=option to see if contract metering should be enabled. Since this is also useful to #17050, might as well make it generic. The goal is to have options passed as `--vm.ewasm=option1:value1,option2:value2,..."