Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts/abi: add function to unpack dynamic data in slice or array #18370

Closed
wants to merge 6 commits into from

Conversation

weimumu
Copy link
Contributor

@weimumu weimumu commented Dec 28, 2018

I change some code to make the abi package can unpack dynamic data in slice or array rightly

@weimumu weimumu requested a review from gballet as a code owner December 28, 2018 10:28
@weimumu
Copy link
Contributor Author

weimumu commented Dec 28, 2018

If I want to be a collaborator of this repository, how can I do. I am very interested in this repository, and I think I can do more thing in this repository. Besides, I have one question. I have contributed a little code to the community, but why i am not the top 100 in contributions.

@weimumu weimumu closed this Jan 1, 2019
@weimumu weimumu reopened this Jan 1, 2019
@weimumu
Copy link
Contributor Author

weimumu commented Jan 4, 2019

accounts/abi: fix bug to unpack dynamic data in slice or array

@gballet
Copy link
Member

gballet commented Jan 10, 2019

Closing this PR as it is superseded by #18406. The tests were interesting so I have created a PR for them at #18424 and specified you as a co-author.

@gballet gballet closed this Jan 10, 2019
@gballet
Copy link
Member

gballet commented Jan 10, 2019

Oh, and in response to your questions, I don't think you have made enough contributions to show up in the insights (at least according to the commit logs). Let's see a couple PRs from now if you still don't show up, we'll investigate then

@gballet gballet modified the milestone: 1.9.0 Jan 16, 2019
@gballet gballet added this to the 1.9.0 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants