Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #19198 - Be defensive in handling getBlock result, it can be nil #19944

Closed
wants to merge 1 commit into from
Closed

Fix #19198 - Be defensive in handling getBlock result, it can be nil #19944

wants to merge 1 commit into from

Conversation

SjonHortensius
Copy link
Contributor

No description provided.

@karalabe
Copy link
Member

This scenario can only happen if the database is corrupted. At that point whether we panic or log.Crit is all the same. There's no point in adding defensive measures for things that cannot happen.

@karalabe karalabe closed this Aug 12, 2019
@SjonHortensius
Copy link
Contributor Author

SjonHortensius commented Aug 12, 2019 •
edited
Loading

@karalabe I don't disagree but you might consider closing #19198 if it isn't fixable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@karalabe karalabe Awaiting requested review from karalabe

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SjonHortensius @karalabe