add node.go unit test file node_test.go #20028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
approved these changes
Nov 5, 2019
holiman
requested changes
Nov 5, 2019
| @@ -0,0 +1,78 @@ | |||
| package trie | |||
rjl493456442
reviewed
Nov 5, 2019
trie/node_test.go
Outdated
| "github.com/ethereum/go-ethereum/rlp" | ||
| ) | ||
|
|
||
| func newFullNode(v []byte) []interface{} { |
karalabe
reviewed
Nov 5, 2019
trie/trie_test.go
Outdated
| rand.Read(elems) | ||
| decodeNode(hash, elems) | ||
| } | ||
| } |
There was a problem hiding this comment.
this test seems useless, and it tests nothing, so i decide to delete it. already rollback.
|
Please also add back the deleted test |
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
* add node.go unit test file node_test.go * add node_test.go file license and rollback trie_test.go * fix unused variable v * trie: fix license year Co-authored-by: Péter Szilágyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add some unit tests for node.go