les: add checkpoint challenge for LES #20125
Conversation
rjl493456442
requested review from
holiman,
karalabe and
zsfelfoldi
as code owners
rjl493456442
changed the title
|
please rebase |
rjl493456442
force-pushed
the
checkpoint-challenge-2
branch
from
6c6312f to
f086977
Compare
|
|
||
| if master { | ||
| d.cancel() | ||
| if d.isMaster(pid) { |
There was a problem hiding this comment.
With this change, you are introducing a gap between checking isMaster and actually doing the cancel. I assume that the cancel now happens later, during UnregisterPeer -- but is it possible that when that happens, the pid is no longer the master?
There was a problem hiding this comment.
d.cancelPeer is only assigned before syncing start at d.synchronise function.
Although we drop the peer but d.synchronising is still 1, so we don't need to worry about the mismatch
There was a problem hiding this comment.
I assume that the
cancelnow happens later
Actually cancel now happen earlier in dropPeer function
|
|
||
| if master { | ||
| s.d.cancel() | ||
| if s.d.isMaster(req.peer.id) { |
|
Can you split this PR into two, one for the light-client related stuff and the downloader stuff |
|
Waiting #20692 to be merged |
It's a PR based on the #20120
This PR first fixes an issue in downloader which introduced in #19413.
Then this PR adds checkpoint challenge for LES too. In short, if the server is not synced or on the difference chain, then it will be rejected very soon.