Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

les: do not disconnect another server #20453

Merged
merged 1 commit into from
Dec 25, 2019

Conversation

zsfelfoldi
Copy link
Contributor

@zsfelfoldi zsfelfoldi commented Dec 12, 2019

This PR explicitly detects in server mode if the other peer is another server. In this case it disables block announcements and short-circuits the protocol handler, sends and expects no messages but does not actively disconnect.

Fixes #17556

Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zsfelfoldi zsfelfoldi merged commit 3bb6815 into ethereum:master Dec 25, 2019
@karalabe karalabe added this to the 1.9.10 milestone Jan 9, 2020
enriquefynn pushed a commit to enriquefynn/go-ethereum that referenced this pull request Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ethereum message handling fails in private proof-of-authority testnet when serving light clients
3 participants