Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/geth: fix forked exe leak in console tests #20480

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

gballet
Copy link
Member

@gballet gballet commented Dec 23, 2019

To test the console's welcome message, an instance of geth is started. If the test detects an invalid output, it will panic and not execute geth.Interrupt so the instances are left running.

@gballet gballet added this to the 1.9.10 milestone Dec 23, 2019
@gballet gballet requested review from fjl and karalabe December 23, 2019 12:13
@fjl fjl merged commit 433937f into ethereum:master Jan 6, 2020
enriquefynn pushed a commit to enriquefynn/go-ethereum that referenced this pull request Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants