Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update module_dashboard.go #20513

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Update module_dashboard.go #20513

merged 1 commit into from
Jan 7, 2020

Conversation

anistark
Copy link
Contributor

@anistark anistark commented Jan 6, 2020

In context of issue #20500

@anistark anistark requested a review from karalabe as a code owner January 6, 2020 12:49
@karalabe karalabe added this to the 1.9.10 milestone Jan 7, 2020
karalabe
karalabe approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@karalabe karalabe merged commit 35f95ae into ethereum:master Jan 7, 2020
@ricardolyn ricardolyn mentioned this pull request Feb 3, 2021
Merged
7 tasks
enriquefynn pushed a commit to enriquefynn/go-ethereum that referenced this pull request Mar 10, 2021
@anistark @enriquefynn
cmd/puppeth: change dashboard title to not use "testnet" (ethereum#20513
6665537 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.10
Development

Successfully merging this pull request may close these issues.
2 participants
@anistark @karalabe