Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth: increase timeout to fix a spurious travis test failure #20560

Merged
merged 1 commit into from
Jan 15, 2020
Merged

eth: increase timeout to fix a spurious travis test failure #20560

merged 1 commit into from
Jan 15, 2020

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Jan 15, 2020

Failure https://travis-ci.org/ethereum/go-ethereum/jobs/636889602#L710 :

ok  	github.com/ethereum/go-ethereum/crypto/ecies	0.061s	coverage: 75.9% of statements
ok  	github.com/ethereum/go-ethereum/crypto/secp256k1	1.472s	coverage: 30.6% of statements
--- FAIL: TestBroadcastBlock (7.12s)
    handler_test.go:634: block broadcast to 3 peers, expected 4
FAIL
coverage: 28.0% of statements
FAIL	github.com/ethereum/go-ethereum/eth	17.103s
ok  	github.com/ethereum/go-ethereum/eth/downloader	41.391s	coverage: 78.3% of statements

This might fix it, at least make it less common

@fjl fjl merged commit f20c8d4 into ethereum:master Jan 15, 2020
@ricardolyn ricardolyn mentioned this pull request Feb 3, 2021
Merged
7 tasks
enriquefynn pushed a commit to enriquefynn/go-ethereum that referenced this pull request Mar 10, 2021
@holiman @enriquefynn
eth: increase timeout to fix a spurious travis test failure (ethereum…
fc83c3d 
…#20560)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl approved these changes

@karalabe karalabe Awaiting requested review from karalabe

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holiman @fjl