cmd/geth/retesteth: use canon head instead of keeping alternate count #20572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retesteth was kind of illogical, when blocks were imported
[1,2,3a,4,3b]
, it thought that3b
was the canon head (since Importblocks does not return an error if a side-block is imported).This PR removes the separate blockNumber counter from the API, and uses the actual current head from
blockchain
when needed.Requested by @winsvega , PTAL if this fixes your issues.