Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/mclock: add NewTimer and Timer.Reset #20634

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Feb 6, 2020

These methods can be helpful when migrating existing timer code.

@fjl fjl force-pushed the common-mclock-chan branch 2 times, most recently from 46e8995 to d91b59c Compare February 6, 2020 21:21
These methods can be helpful when migrating existing timer code.
@fjl fjl force-pushed the common-mclock-chan branch from d91b59c to caca997 Compare February 6, 2020 22:29
@fjl fjl requested a review from karalabe February 7, 2020 09:45
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl
Copy link
Contributor Author

fjl commented Feb 11, 2020

@karalabe PTAL

@fjl fjl merged commit c22fdec into ethereum:master Feb 11, 2020
enriquefynn pushed a commit to enriquefynn/go-ethereum that referenced this pull request Mar 10, 2021
These methods can be helpful when migrating existing timer code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants