accounts: add walletsNoLock to avoid double read lock #20655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
approved these changes
Feb 12, 2020
fjl
changed the title
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 3, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 3, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 4, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 6, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 7, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 7, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 7, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 9, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the https://golang.org/pkg/sync/ says about RLock:
It should not be used for recursive read locking; a blocked Lock call excludes new readers from acquiring the lock.So double read lock should also be avoided.
The first RLock is
am.lock.RLock()in funcWallet(), the second RLock is in its callee funcWallets().The fix is to add a new func
walletsNoLock()and letWallet()andWallets()call it.