rpc: remove startup error for invalid modules, log it instead #20684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the error added in ethereum#20597 in favor of a log message at error level. Failing to start broke a bunch of people's setups and is probably not the right thing to do for this check.
This was referenced Feb 17, 2020
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
…um#20684) This removes the error added in ethereum#20597 in favor of a log message at error level. Failing to start broke a bunch of people's setups and is probably not the right thing to do for this check.
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 4, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 8, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 8, 2024
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 8, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 8, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 8, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 8, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 8, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the error added in #20597 in favor of a log message at
error level. Failing to start broke a bunch of people's setups and is
probably not the right thing to do for this check.