cmd/geth, cmd/utils: remove legacy rpc flags

[tqpcharlie]

Closes #23267

This PR aims to remove the legacy RPC flags that say "deprecated, will be removed in June 2021".

[tqpcharlie]

just curious, can I remove the rpcport flag in cmd/clef/main.go or is that seperate from the deprecated --rpcport flag?

[tqpcharlie]

am I missing something I need to remove? I've looked, and I honestly can't tell.

[karalabe]

The code doesn't compile.

[tqpcharlie]

I'm struggling to figure out what went wrong here:
cmd/utils/flags.go:1787:2: expected declaration, found 'switch' (typecheck)

switch {

^

[tqpcharlie]

travis ci seems to be stuck...

[tqpcharlie]

just curious, can I remove the rpcport flag in cmd/clef/main.go or is that seperate from the deprecated --rpcport flag?

[tqpcharlie]

can I get a review and/or merge for this, please?

[MariusVanDerWijden]

@Zachinquarantine This PR does not compile. It doesn't even lint: https://app.travis-ci.com/github/ethereum/go-ethereum/jobs/533060458
You should set up your go environment in a way that automatically lints and run go test ./... before you submit your PRs.

[holiman]

cmd/utils/flags.go:923:2: expected declaration, found 'if' (typecheck)
	if ctx.GlobalBool(HTTPEnabledFlag.Name) && cfg.HTTPHost == "" {
	^
cmd/utils/flags.go:1082:2: expected declaration, found 'if' (typecheck)
	if ctx.GlobalIsSet(MinerEtherbaseFlag.Name) {
	^
cmd/utils/flags.go:1401:3: expected declaration, found 'if' (typecheck)
		if err = hash.UnmarshalText([]byte(parts[1])); err != nil {
		^
cmd/utils/flags.go:1423:36: expected 'IDENT', found ')' (typecheck)
			switch option := args[i+1].(type) {
			                                ^
cmd/utils/flags.go:1424:15: expected ';', found ':' (typecheck)
			case string:

You should be able to detect compilation issues via make geth or make all. And as others have pointed out running the tests locally is often a good idea.

[tqpcharlie]

cmd/utils/flags.go:923:2: expected declaration, found 'if' (typecheck)
	if ctx.GlobalBool(HTTPEnabledFlag.Name) && cfg.HTTPHost == "" {
	^
cmd/utils/flags.go:1082:2: expected declaration, found 'if' (typecheck)
	if ctx.GlobalIsSet(MinerEtherbaseFlag.Name) {
	^
cmd/utils/flags.go:1401:3: expected declaration, found 'if' (typecheck)
		if err = hash.UnmarshalText([]byte(parts[1])); err != nil {
		^
cmd/utils/flags.go:1423:36: expected 'IDENT', found ')' (typecheck)
			switch option := args[i+1].(type) {
			                                ^
cmd/utils/flags.go:1424:15: expected ';', found ':' (typecheck)
			case string:

You should be able to detect compilation issues via make geth or make all. And as others have pointed out running the tests locally is often a good idea.

I've ran the tests locally, and this is the only error the compiler is giving me:

cmd/utils/flags.go:923:2: expected declaration, found 'if' (typecheck)
if ctx.GlobalBool(HTTPEnabledFlag.Name) && cfg.HTTPHost == "" {

[MariusVanDerWijden]

The linter is still red: https://app.travis-ci.com/github/ethereum/go-ethereum/jobs/533787275
You need to goimport -ed your files. What kind of IDE are you using? Goland and VSCode should do that automatically for you

[tqpcharlie]

The linter is still red: app.travis-ci.com/github/ethereum/go-ethereum/jobs/533787275
You need to goimport -ed your files. What kind of IDE are you using? Goland and VSCode should do that automatically for you

I'm using VSCode, but for some reason it hasn't fixed the goimports error when I save the file.

[tqpcharlie]

The linter is still red: app.travis-ci.com/github/ethereum/go-ethereum/jobs/533787275
You need to goimport -ed your files. What kind of IDE are you using? Goland and VSCode should do that automatically for you

I'm using VSCode, but for some reason it hasn't fixed the goimports error when I save the file.

Turns out it was because I hadn't configured it properly, it now passes 🎉 @MariusVanDerWijden

[MariusVanDerWijden]

LGTM
(This will probably break a lot of users though, as there are a lot of tutorials out there with these legacy flags)

[collinpowell]

Please how do i get my rpc port default is not connecting to metamask