Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: remove unused error from TxPool.Pending #23720

Merged
merged 3 commits into from
Oct 13, 2021
Merged

core: remove unused error from TxPool.Pending #23720

merged 3 commits into from
Oct 13, 2021

Conversation

jwasinger
Copy link
Contributor

The method TxPool.Pending doesn't ever return an error so it makes sense to remove it from the method signature.

holiman
holiman approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fjl
fjl requested changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fail.

fjl
fjl approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tests are OK now.

@fjl fjl merged commit 011fe3e into ethereum:master Oct 13, 2021
@fjl fjl added this to the 1.10.10 milestone Oct 13, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Oct 14, 2021
@jwasinger
core: remove unused error from TxPool.Pending (ethereum#23720)
62a5c24
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
@jwasinger @zzyalbert
core: remove unused error from TxPool.Pending (ethereum#23720)
499445d
@gzliudan gzliudan mentioned this pull request May 17, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
b0bca60
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
44faee8
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
fd8c78b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
3fbed1a
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
8cef4c1
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
e767b8b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
d222e08
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
4421feb
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
0374ee9
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
b90b880
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
9300204
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
0d01d20
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
f46bd10
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
0d7183b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
db9e63b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
d8e9a82
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
0a56a12
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
b021e14
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
629b5e0
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
5968159
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
9de9c66
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
4f7e4cf
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
bb93e56
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
24e10e5
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 29, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
d534355
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 30, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
b582082
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
217938f
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
57aee7d
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 1, 2024
@gzliudan
core: remove unused error from TxPool.Pending (ethereum#23720)
e5fb0b4
wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Nov 13, 2024
@gzliudan @wanwiset25
core: remove unused error from TxPool.Pending (ethereum#23720)
e0125c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl approved these changes

@holiman holiman holiman approved these changes

@gballet gballet Awaiting requested review from gballet

@karalabe karalabe Awaiting requested review from karalabe

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.10
Development

Successfully merging this pull request may close these issues.
3 participants
@jwasinger @fjl @holiman