Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: use same receiver names #24252

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Chore: use same receiver names #24252

merged 2 commits into from
Jan 20, 2022

Conversation

aeharvlee
Copy link
Contributor

@aeharvlee aeharvlee commented Jan 19, 2022 •
edited
Loading

Using same receiver name will be greater than using different name.

@fjl
Copy link
Contributor

fjl commented Jan 19, 2022

If you rename the receiver, you must also apply this renaming in the method body.

@aeharvlee
Copy link
Contributor Author

@fjl

Thanks. I'll follow that.

@aeharvlee
Copy link
Contributor Author

@fjl
I updated method body also. Thanks for your feedback.

@karalabe karalabe added this to the 1.10.16 milestone Jan 20, 2022
@karalabe
Copy link
Member

Thank you

@karalabe karalabe merged commit 03aaea1 into ethereum:master Jan 20, 2022
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Jan 20, 2022
@aeharvlee
internal/ethapi: use same receiver names (ethereum#24252)
d697f53 
* Chore: use same receiver names

* Fix syntax issues
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
@aeharvlee @JacekGlen
internal/ethapi: use same receiver names (ethereum#24252)
466d208 
* Chore: use same receiver names

* Fix syntax issues
@gzliudan gzliudan mentioned this pull request Jun 13, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
036c552
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
fb9c4b9
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
da9a551
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
7a36ff5
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
622356c
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 10, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
dd80a82
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
32a7fa5
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
4352784
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
54598fe
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
c18bca1
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
2ef0995
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
9943c00
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
8206774
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
62bee38
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
943126e
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
fcdad23
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
723b5f8
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
5cf6236
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
b6c5884
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
5ec128e
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
bbd890f
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
4a03722
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
84a0895
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
8b6efb9
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 29, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
3b892e3
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 30, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
35f6353
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
134a812
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
f46326b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 1, 2024
@gzliudan
internal/ethapi: use same receiver names (ethereum#24252)
588847c
wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Nov 13, 2024
@gzliudan @wanwiset25
internal/ethapi: use same receiver names (ethereum#24252)
7ad7484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.16
Development

Successfully merging this pull request may close these issues.
3 participants
@aeharvlee @fjl @karalabe