cmd/geth: print version on geth start #2622
Conversation
Updated: Wed Jun 8 14:13:58 UTC 2016 |
|
You added this line to the geth subcommand. That means if the users starts geth with a different subcommand, e.g. the console subcommand it would not print the version. Printing the version is only interesting when the node is actually started. Therefore a better place would be in the We also use the convention to specify the package name in the commit message. |
|
I've moved it to the startNode function and changed the commit message format. Does that look fine? |
mattdf
changed the title
Current coverage is 56.39%@@ develop #2622 diff @@
==========================================
Files 215 215
Lines 24506 24575 +69
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 13821 13859 +38
- Misses 10682 10715 +33
+ Partials 3 1 -2
|
|
LGTM 👍 |
| @@ -434,6 +434,8 @@ func execScripts(ctx *cli.Context) { | |||
| // it unlocks any requested accounts, and starts the RPC/IPC interfaces and the | |||
| // miner. | |||
| func startNode(ctx *cli.Context, stack *node.Node) { | |||
| // Report geth version | |||
| glog.V(logger.Info).Infof("instance: Geth/%s/%s/%s\n", verString, runtime.Version(), runtime.GOOS) | |||
There was a problem hiding this comment.
Please use utils.MakeNodeName(clientIdentifier, verString, ctx) instead of manually constructing the name. Also there's no need for the \n at the end of the log message. Also please rename instance: to Node version: (note, capitalized).
|
PS: Please also squash your commits into a single one :) ( |
For feature request #2609 - print version on geth start to help development / debugging when using different geth instances.