console: use default APIs when server doesn't have rpc_modules #26267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
approved these changes
Nov 28, 2022
|
Just out of curiosity in what situation do you need this? i.e. when is |
|
The error happens with |
s1na
reviewed
Nov 28, 2022
| @@ -198,13 +199,22 @@ func (c *Console) initWeb3(bridge *bridge) error { | |||
| return err | |||
| } | |||
|
|
|||
| var defaultAPIs = map[string]string{"eth": "1.0", "net": "1.0", "debug": "1.0"} | |||
There was a problem hiding this comment.
I'd remove debug since it's not exposed by default.
There was a problem hiding this comment.
I'd leave as much as possible -- even if it's not enabled. If we don't know whether it's enabled or not, at least we can leave it up to the user to figure out. Otherwise we'll basically deny access, with no way to enable it, and no way for the end-user to test if it works or not.
9 tasks
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was already proposed in #25148, but that PR got closed for some reason. I recently needed this functionality myself, so here we go again.