-
Notifications
You must be signed in to change notification settings - Fork 20.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/rawdb: remove unused deriveLogFields #29913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
changed the title
core/rawdb: move deriveLogFields into the test file
core/rawdb: remove unused deriveLogFields
Jun 4, 2024
rjl493456442
approved these changes
Jun 4, 2024
holiman
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, otherwise LGTM
Co-authored-by: Martin HS <[email protected]>
Co-authored-by: Martin HS <[email protected]>
jorgemmsilva
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Jun 17, 2024
Co-authored-by: Gary Rong <[email protected]> Co-authored-by: Martin HS <[email protected]>
stwiname
pushed a commit
to subquery/data-node-go-ethereum
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Gary Rong <[email protected]> Co-authored-by: Martin HS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deriveLogFields
is a testing-only function and can be replaced with another one. This pull request deprecates this "unused" function for clean up.