Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/state: Fix memory expansion bug by not copying clean objects #3006

Merged
merged 1 commit into from
Sep 19, 2016
Merged

core/state: Fix memory expansion bug by not copying clean objects #3006

merged 1 commit into from
Sep 19, 2016
+8 −5

Conversation

Arachnid
Copy link
Contributor

No description provided.

@mention-bot
Copy link

@Arachnid, thanks for your PR! By analyzing the annotation information on this pull request, we identified @obscuren, @fjl and @karalabe to be potential reviewers

@karalabe
Copy link
Member

LGTM 👍 Would be nice to try a sing from scratch and wait a bit for it to process a 2-300K blocks.

karalabe
karalabe approved these changes Sep 19, 2016
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Doing a sync from 0 now.

@ChuckSRQ ChuckSRQ mentioned this pull request Sep 19, 2016
Closed
obscuren
obscuren approved these changes Sep 19, 2016
View reviewed changes
Copy link
Contributor

@obscuren obscuren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@karalabe karalabe merged commit 88b012a into ethereum:develop Sep 19, 2016
This was referenced Sep 19, 2016
Closed
Closed
@vivek0
Copy link

vivek0 commented Oct 5, 2016

Repeating seems stuck at #2376500

I1005 07:47:22.129315 core/blockchain.go:214] Last header: #2376500 [6424ea5c…] TD=69418447161679106568
I1005 07:47:22.129348 core/blockchain.go:215] Last block: #2376500 [6424ea5c…] TD=69418447161679106568
I1005 07:47:22.129364 core/blockchain.go:216] Fast block: #2376500 [6424ea5c…] TD=69418447161679106568

@holgerd77 holgerd77 mentioned this pull request Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obscuren obscuren obscuren approved these changes

@karalabe karalabe karalabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Arachnid @mention-bot @karalabe @vivek0 @obscuren