rpc: remove HexBytes, HexNumber #3475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inspect was broken by ffaf58f (May 2016!). Looks like nobody uses this function.
The message now includes the index of the invalid arg.
|
@fjl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zsfelfoldi, @bas-vk and @karalabe to be potential reviewers. |
This change couldn't be automated because HexNumber was used for numbers of all sizes.
fjl
force-pushed
the
rpc-hex-improvements
branch
from
6be90f7 to
5071b20
Compare
fjl
force-pushed
the
rpc-hex-improvements
branch
from
5071b20 to
12c964b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2438
Fixes for other minor issues are also included as separate commits.