p2p: disable encryption handshake, enable log events #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diff is a bit bigger than expected because the protocol handshake logic has moved out of Peer. This is necessary because the protocol handshake will have custom framing in the final protocol.
This should prevent connection drops.
obscuren
added a commit
that referenced
this pull request
Feb 19, 2015
p2p: disable encryption handshake, enable log events
AusIV
pushed a commit
to NoteGio/go-ethereum
that referenced
this pull request
Jul 12, 2021
…-1.16 .travis.yml: fix typos in arm64 job go version (should be 1.16.x)
weiihann
pushed a commit
to weiihann/go-ethereum
that referenced
this pull request
Feb 2, 2024
Signed-off-by: Ignacio Hagopian <[email protected]>
s1na
pushed a commit
to s1na/go-ethereum
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes restore interoperability with cpp-ethereum. The encryption handshake will come back after PoC 8 is released.