Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/utils: fix comma-separated --bootnodes #3548

Merged
merged 1 commit into from
Jan 11, 2017
Merged

cmd/utils: fix comma-separated --bootnodes #3548

merged 1 commit into from
Jan 11, 2017

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Jan 10, 2017

Fixes #3547

@fjl fjl added the review label Jan 10, 2017
@mention-bot
Copy link

@fjl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @karalabe, @zsfelfoldi and @obscuren to be potential reviewers.

@fjl fjl force-pushed the geth-fix-bootnodes branch from 72bee3d to 445deb7 Compare January 10, 2017 20:13
@fjl fjl changed the title cmd/utils: fix passing of comma-separated --bootnodes cmd/utils: fix comma-separated --bootnodes Jan 10, 2017
karalabe
karalabe approved these changes Jan 11, 2017
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit 2b4d0b6 into ethereum:master Jan 11, 2017
@obscuren obscuren removed the review label Jan 11, 2017
@karalabe karalabe added this to the 1.5.7 milestone Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.7
Development

Successfully merging this pull request may close these issues.
4 participants
@fjl @mention-bot @karalabe @obscuren