tree: getproofitems replace children with resolved node #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
commented
Oct 17, 2023
| @@ -873,6 +873,7 @@ func (n *InternalNode) GetProofItems(keys keylist, resolver NodeResolverFn) (*Pr | |||
| if err != nil { | |||
| return nil, nil, nil, err | |||
| } | |||
| n.children[i] = c | |||
There was a problem hiding this comment.
If we don't do this, the line below pec, es, other, err := n.children[childIdx].GetProofItems(group, resolver) (L930) would fail since n.children[childrenIdx] can be a HashedNode and GetProofItems isn't allowed.
1 task
gballet
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the resolved nodes from
GetProofItemsreplace theHashedNodes.If we don't do this, this method can fail for unresolved nodes despite technically receiving a
resolvervia params. I'll point out the exact situation in the PR comment.This allows Geth to avoid "warmup" pre-trie: gballet/go-ethereum#293