Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More precise smt address encoding #376

Closed
wants to merge 3 commits into from

Conversation

d-xo
Copy link
Collaborator

@d-xo d-xo commented Sep 11, 2023

Description

This adds some more assertions during encoding around the values of symbolic addresses. Still needed is a pass that asserts that all symbolic addresses are pairwise distinct with all known concrete addresses.

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@d-xo d-xo force-pushed the more-precise-smt-address-encoding branch from 60f3655 to 2b2e911 Compare September 13, 2023 13:20
@d-xo d-xo marked this pull request as ready for review September 14, 2023 17:22
@d-xo d-xo force-pushed the more-precise-smt-address-encoding branch from 01bb9f6 to b6391db Compare September 14, 2023 17:25
Adds constraints that ensure that symbolic addresses that are used to
key the contracts mapping cannot alias any other keys.
@d-xo d-xo force-pushed the more-precise-smt-address-encoding branch from b6391db to 05a1c6a Compare September 18, 2023 17:44
Copy link
Collaborator

@msooseth msooseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is actually really good!

@msooseth
Copy link
Collaborator

I have fixed this up and it's working now, yay! The new PR is at: #641

Closing so we can review and merge that PR instead :)

@msooseth msooseth closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants