clients/besu: fix clique mining #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reversed the logic to deploy clique key to bootnode only. Original change was to avoid deploying the same clique key to 2 different nodes. Ended up stopping the deployment of the clique key to the first node causing test that rely on a single node to mine to fail due to timeout.
mattsse
pushed a commit
to mattsse/hive
that referenced
this pull request
Mar 24, 2023
Reversed the logic to deploy clique key to bootnode only. Original change was to avoid deploying the same clique key to 2 different nodes. Ended up stopping the deployment of the clique key to the first node, causing test that rely on a single node to mine to fail due to timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverse the logic to deploy clique key to bootnode only.
This commit 104c185 introduced an additional check to prevent deploying the same private key to a second node. Accidentally ended up stopping the deployment of the key for the first node which prevents besu from mining a block using clique and broke a couple of the RPC suite tests.
Please kindly review that and let me know if there's any additional changes required.
This change has been tested running hive locally and fixes the RPC suite. Didn't detect any new regression