Run Berlin ethethereum/tests, except for modexp-related ones #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
force-pushed
the
run-berlin-eth-tests-minus-modexp
branch
from
cbd3a39 to
bff9a26
Compare
When comparing rlp objects in blockchain tests, the actual & expected values were flipped! That was a drag that slowed down debugging... Also, include a diff on integer values, which can help quickly identify the problem. For example, if the gas costs are wrong, the difference will often be a clear indicator.
This makes pytest-watch usable, so it doesn't try to load *all* fixture tests on every run. For example, you can now use: ptw tests/json-fixtures/blockchain eth
carver
force-pushed
the
run-berlin-eth-tests-minus-modexp
branch
from
bff9a26 to
712f1c6
Compare
For example: RevertInCreateInInitCreate2_d0g0v0_Berlin
carver
force-pushed
the
run-berlin-eth-tests-minus-modexp
branch
from
712f1c6 to
4a77750
Compare
|
Verbal 👍 from @kclowes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Need to run Berlin tests #1991
(Can't close the issue until #1988 and maybe other modexp issues are solved)
How was it fixed?
When #1988 is resolved, remove the
-k "not modexp". (Presumably in a different PR, depending on merge order)To-Do
Cute Animal Picture