Implement difficulty calculation for homestead #35
Conversation
gsalgado
force-pushed
the
homestead-difficulty
branch
from
345aa91 to
d750c6e
Compare
| ('header', BlockHeader), | ||
| ('transactions', CountableList(HomesteadTransaction)), | ||
| ('uncles', CountableList(BlockHeader)) | ||
| ] |
There was a problem hiding this comment.
Side note:
It would be nice if rlp objects supported proper inheritance in much the same way as django models work. We'd need a metaclass to inherit from and a Field class of some sort for each field. Would be a better/nicer interface and would allow more fine-grained subclassing
There was a problem hiding this comment.
Indeed, that'd be nice
There was a problem hiding this comment.
I'm gonna open an issue over there.
There was a problem hiding this comment.
in case anyone cares ethereum/pyrlp#44
| if fixture_name.startswith('Homestead'): | ||
| evm = EVM.configure( | ||
| 'HomesteadEVM', | ||
| vm_configuration=[(0, HomesteadVM)]) |
There was a problem hiding this comment.
note
It would be great if we can figure out an API for re-configuring start block numbers that was more elegant. Fully re-specifying the vm_configuration is not elegant. It isn't clear what this looks like but seemed worth surfacing to get more people thinking about it.
There was a problem hiding this comment.
Yeah, I agree the current approach is not the most elegant, but if this turns out to be the only place where we'd use it, it may not be worth the effort. I'll add a TODO to make sure we re-evaluate the possibility of doing what you suggest later, if that's ok with you.
There was a problem hiding this comment.
Sounds great. Just leaving these things as I see them to try and keep both a record and a personal understanding of where some of the "bodies are buried". Not even sure it's worth the TODO.
|
Just looked over this. Looks good. Lemme know what the status is and whether you're ready for final review/merge. |
gsalgado
force-pushed
the
homestead-difficulty
branch
from
d750c6e to
d95ba73
Compare
|
I've added a TODO for the API to reconfigure start blocks; if you're ok with that I think this is ready for final review/merge |
|
will merge when it is green. Thanks |
No description provided.