-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contract that reverts with Solidity Custom Error fails to deploy to Javascript VM #1138
Comments
dwardu
changed the title
Contract that reverts with Solidity Custom Error fails to deploy
Contract that reverts with Solidity Custom Error fails to deploy to Javascript VM
Apr 22, 2021
I guess this issue will be closed when ethers-io/ethers.js#1498 is closed and merged into this project. |
this should be fixed in remix.ethereum.org in an hour. Alpha is already updated |
@LianaHus Cool. Thanks. TBH I was waiting for ethers-io/ethers.js#1498 fix to be announced, and was intending to create a PR with the dependency upgrade 😊 Was it fixed in a different way? |
ethers.js (5.1.4) was published I think yesterday. thanks anyway :)
…On Wed, Apr 28, 2021 at 1:41 PM Edward Grech ***@***.***> wrote:
@LianaHus <https://github.com/LianaHus> Cool. Thanks.
TBH I was waiting for ethers-io/ethers.js#1498
<ethers-io/ethers.js#1498> fix to be announced,
and was intending to create a PR with the dependency upgrade 😊 Was it
fixed in a different way?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1138 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJ4S3EZLB2XBVGD34KE4H3TK7YANANCNFSM43M5WZPQ>
.
|
… On Wed, Apr 28, 2021 at 1:50 PM Liana Husikyan ***@***.***> wrote:
ethers.js (5.1.4) was published I think yesterday. thanks anyway :)
On Wed, Apr 28, 2021 at 1:41 PM Edward Grech ***@***.***>
wrote:
> @LianaHus <https://github.com/LianaHus> Cool. Thanks.
>
> TBH I was waiting for ethers-io/ethers.js#1498
> <ethers-io/ethers.js#1498> fix to be
> announced, and was intending to create a PR with the dependency upgrade
> 😊 Was it fixed in a different way?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1138 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACJ4S3EZLB2XBVGD34KE4H3TK7YANANCNFSM43M5WZPQ>
> .
>
|
Ok! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using the contract from the Custom Errors explainer blog post:
The contract compiles correctly in Remix IDE, and ABI is created correctly:
But deployment to Javascript VM fails with following error:
On the other hand, deployment to Rinkeby succeeds.
The text was updated successfully, but these errors were encountered: