Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require and Assert. #1765

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Require and Assert. #1765

merged 1 commit into from
Mar 14, 2017

Conversation

chriseth
Copy link
Contributor

@chriseth chriseth commented Mar 9, 2017

Fixes #1762

(instruction ``0xfe``) if a runtime exception is encountered. In both cases, this causes
Internally, Solidity performs a revert operation (instruction ``0xfd``) when a user-provided exception is thrown or the condition of
a ``require`` call is not met. In contrast, it performs an invalid operation
(instruction ``0xfe``) if a runtime exception is encountered or the condition of an ``assert`` call is not met. In both cases, this causes. In both cases, this causes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"In both cases, this causes" is duplicated.

@pirapira
Copy link
Member

Please rebase.

@chriseth
Copy link
Contributor Author

Rebased.

Copy link
Member

@pirapira pirapira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pirapira pirapira merged commit 409eb9e into develop Mar 14, 2017
@pirapira pirapira deleted the requireAssert branch March 14, 2017 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants