Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow raw callcode (was deprecated in 0.4.12) #4313

Merged
merged 1 commit into from
Jun 19, 2018
Merged

Conversation

axic
Copy link
Member

@axic axic commented Jun 18, 2018

No description provided.

@axic axic force-pushed the remove-callcode branch from d17c4db to c3044ac Compare June 18, 2018 15:09
@axic axic requested review from chriseth and ekpyron June 18, 2018 15:09
@axic axic force-pushed the remove-callcode branch from c3044ac to 75c97ee Compare June 18, 2018 15:31
@axic
Copy link
Member Author

axic commented Jun 18, 2018

@chriseth since this practically removes the possibility of using callcode, should we also remove it from CallKind on the ExpressionCompiler?

Changelog.md Outdated
@@ -8,6 +8,7 @@ Breaking Changes:
* Commandline interface: Require ``-`` if standard input is used as source.
* General: ``continue`` in a ``do...while`` loop jumps to the condition (it used to jump to the loop body). Warning: this may silently change the semantics of existing code.
* General: Disallow declaring empty structs.
* General: Disallow raw ``callcode`` (was already deprecated in 0.4.12).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify that that this is just about the address member and not the assembly opcode.

Copy link
Contributor

@chriseth chriseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine apart from the changelog entry. Yes, we can remove the kind enum values, but please as part of a separate PR.

@axic axic force-pushed the remove-callcode branch from 75c97ee to a170595 Compare June 19, 2018 17:31
@axic
Copy link
Member Author

axic commented Jun 19, 2018

Updated.

@axic axic merged commit c9ff67c into develop Jun 19, 2018
@axic axic deleted the remove-callcode branch June 19, 2018 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants