Tests for flipping signs on signed type edge case #5213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
changed the title
chriseth
suggested changes
Oct 15, 2018
| } | ||
| )"; | ||
| compileAndRun(sourceCode); | ||
| ABI_CHECK(callContractFunction("f()"), encodeArgs(u256(0))); |
There was a problem hiding this comment.
The function returns true, so this should be encodeArgs(true). Apart from that, perfect!
There was a problem hiding this comment.
Thanks for the feedback! I did a rebase though, not sure if that's the proper procedure here or if I should've just not updated and pushed the fix anyways.
Edit: Fixed the rebase issue!
Codecov Report
@@ Coverage Diff @@
## develop #5213 +/- ##
===========================================
+ Coverage 87.87% 87.87% +<.01%
===========================================
Files 317 317
Lines 32023 32027 +4
Branches 3826 3826
===========================================
+ Hits 28139 28143 +4
Misses 2586 2586
Partials 1298 1298
|
|
Great! Could you squash the two commits into a single one? Then this is ready to be merged. |
|
Squashed the commits |
chriseth
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes #5103
Checklist
Description
I may have missed a few things, it's my first time working on a programming language.
Since Issue #5103 's references EndToEndSuite, I made the test in the SolidityEndToEnd.cpp.
Hopefully the integrated tests won't be too mad. If I'm missing any fundamental things, misunderstood something or if I should add another case in the same test, let me know. Cheers!