Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes codespell #7419

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Fixes codespell #7419

merged 1 commit into from
Sep 12, 2019

Conversation

erak
Copy link
Collaborator

@erak erak commented Sep 12, 2019

Fixes:

./libevmasm/RuleList.h:51: hist  ==> heist, his
./libevmasm/RuleList.h:51: hist  ==> heist, his
./docs/yul.rst:247: varn  ==> warn
./docs/yul.rst:248: varn  ==> warn
./docs/yul.rst:249: varn  ==> warn
./docs/yul.rst:252: varn  ==> warn
./test/compilationTests/corion/provider.sol:152: datas  ==> data
./test/compilationTests/corion/provider.sol:275: datas  ==> data
./test/compilationTests/corion/provider.sol:326: datas  ==> data

@@ -9,3 +9,5 @@ ba
fo
compilability
errorstring
varn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use var_n instead?

Copy link
Collaborator Author

@erak erak Sep 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, then we would need to apply that everywhere like arg1, argn, l1, ..., ln.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are only 2 places, right?

@ekpyron
Copy link
Member

ekpyron commented Sep 12, 2019

By the way errorstring and assignend are both in the whitelist, but we only have errorString and assignEnd in the repo - is it possible to make codespell gracefully deal with camelCase? Unrelated to this PR, though. [EDIT: https://github.com/codespell-project/codespell/issues/196 and https://github.com/codespell-project/codespell/issues/314 - doesn't look like it currently]

@chriseth chriseth merged commit 02af613 into develop Sep 12, 2019
@chriseth chriseth deleted the checkspell-fix branch September 12, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants