Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require "payable" modifier if function wants to receive ether. #958

Closed
wants to merge 1 commit into from

Conversation

chriseth
Copy link
Contributor

@chriseth chriseth commented Aug 26, 2016

Work in progress

Replaces #665

Partially implements #500 and #563. Comments welcome.

Fixes #602.

todo:

  • library function should not be payable
  • contract is payable should create payable fallback function (and error if there already is one)
  • calling a non-payable function with value set should report an error
  • accessor functions should not be able to receive ether (-> callvalue check should probably move to dispatcher)
  • internal functions should not allow payable modifier
  • overwriting a base contract function should not change payable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants