-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remix plugin: Fix Blockscout explorer links #1530
Comments
The issue seems to be that we are opening the link from an sandboxed iframe and the blockscout server sets this http header: |
I think this problem will actually not persist once the plugin is a native Remix plugin, because it won't be running inside an iframe anymore. Therefore, I'm closing this issue. |
I was wrong about the assumption that it won't be running in an iframe. If there isn't a fix for this we might have to disable Blockscout links. |
Had a look at the problem again and it seems adding Here is a minimal reproduction btw: https://gist.github.com/manuelwedler/b39f3fe377f39683c2128138c3d4e5a0 |
Hotfix for the links as they were not working, see ethereum/sourcify#1530
Implemented a hotfix for this here: ethereum/remix-project#5435 |
Hotfix for the links as they were not working, see ethereum/sourcify#1530
Hotfix for the links as they were not working, see ethereum/sourcify#1530
Merged |
When clicking the link to the contract code on Blockscout, the
Blockscout instance blocks the http requestbrowser blocks loading the resource. The URL seems to be fine as copying it to a fresh tab works. I think this might be related to the http request origin. We need to see if it is fixable, or otherwise report it to Blockscout.The text was updated successfully, but these errors were encountered: