Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix plugin: Fix Blockscout explorer links #1530

Closed
manuelwedler opened this issue Aug 6, 2024 · 6 comments
Closed

Remix plugin: Fix Blockscout explorer links #1530

manuelwedler opened this issue Aug 6, 2024 · 6 comments
Assignees

Comments

@manuelwedler
Copy link
Contributor

manuelwedler commented Aug 6, 2024

When clicking the link to the contract code on Blockscout, the Blockscout instance blocks the http request browser blocks loading the resource. The URL seems to be fine as copying it to a fresh tab works. I think this might be related to the http request origin. We need to see if it is fixable, or otherwise report it to Blockscout.

@manuelwedler
Copy link
Contributor Author

The issue seems to be that we are opening the link from an sandboxed iframe and the blockscout server sets this http header: cross-origin-opener-policy: same-origin

@ethereum ethereum deleted a comment Aug 8, 2024
@ethereum ethereum deleted a comment Aug 9, 2024
@ethereum ethereum deleted a comment Aug 9, 2024
@manuelwedler
Copy link
Contributor Author

I think this problem will actually not persist once the plugin is a native Remix plugin, because it won't be running inside an iframe anymore. Therefore, I'm closing this issue.

@github-project-automation github-project-automation bot moved this from Sprint - Blocked to Sprint - Done in Sourcify Public Sep 2, 2024
@manuelwedler
Copy link
Contributor Author

I was wrong about the assumption that it won't be running in an iframe. If there isn't a fix for this we might have to disable Blockscout links.

@manuelwedler manuelwedler reopened this Sep 24, 2024
@github-project-automation github-project-automation bot moved this from COMPLETED to Triage in Sourcify Public Sep 24, 2024
@ethereum ethereum deleted a comment Sep 24, 2024
@manuelwedler
Copy link
Contributor Author

Had a look at the problem again and it seems adding allow-popups-to-escape-sandbox to the iframe's sandbox attribute would solve it. I will ask the Remix team if it will be possible to add it.

Here is a minimal reproduction btw: https://gist.github.com/manuelwedler/b39f3fe377f39683c2128138c3d4e5a0

@manuelwedler
Copy link
Contributor Author

Implemented a hotfix for this here: ethereum/remix-project#5435

@manuelwedler manuelwedler moved this from Sprint - In Progress to Sprint - Blocked in Sourcify Public Nov 28, 2024
manuelwedler added a commit to sourcifyeth/remix-project that referenced this issue Nov 29, 2024
Aniket-Engg pushed a commit to ethereum/remix-project that referenced this issue Nov 29, 2024
@manuelwedler manuelwedler moved this from Sprint - Blocked to Sprint - Done in Sourcify Public Nov 29, 2024
@manuelwedler
Copy link
Contributor Author

Merged

@marcocastignoli marcocastignoli moved this from Sprint - Done to COMPLETED in Sourcify Public Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant