Progress bars for key generation #144
Merged
+24
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
approved these changes
Nov 3, 2020
|
|
||
| def export_keystores(self, password: str, folder: str) -> List[str]: | ||
| return [credential.save_signing_keystore(password=password, folder=folder) for credential in self.credentials] | ||
| with click.progressbar(self.credentials, label='Creating your keystores:\t', |
There was a problem hiding this comment.
nitpicking: should we keep using "(s)"?
Suggested change
| with click.progressbar(self.credentials, label='Creating your keystores:\t', | |
| with click.progressbar(self.credentials, label='Creating your keystore(s):\t', |
|
|
||
| def export_deposit_data_json(self, folder: str) -> str: | ||
| deposit_data = [cred.deposit_datum_dict for cred in self.credentials] | ||
| with click.progressbar(self.credentials, label='Creating your depositdata:\t', |
There was a problem hiding this comment.
Suggested change
| with click.progressbar(self.credentials, label='Creating your depositdata:\t', | |
| with click.progressbar(self.credentials, label='Creating your deposit data:\t', |
| filefolder = os.path.join(folder, 'deposit_data-%i.json' % time.time()) | ||
| with open(filefolder, 'w') as f: | ||
| json.dump(deposit_data, f, default=lambda x: x.hex()) | ||
| return filefolder | ||
|
|
||
| def verify_keystores(self, keystore_filefolders: List[str], password: str) -> bool: | ||
| return all(credential.verify_keystore(keystore_filefolder=filefolder, password=password) | ||
| for credential, filefolder in zip(self.credentials, keystore_filefolders)) | ||
| with click.progressbar(zip(self.credentials, keystore_filefolders), label='Verifying your keystores:\t', |
There was a problem hiding this comment.
Suggested change
| with click.progressbar(zip(self.credentials, keystore_filefolders), label='Verifying your keystores:\t', | |
| with click.progressbar(zip(self.credentials, keystore_filefolders), label='Verifying your keystore(s):\t', |
Comment on lines
+114
to
+118
| Creating your keys: [####################################] <N>/<N> | ||
| Creating your keystores: [####################################] <N>/<N> | ||
| Creating your depositdata: [####################################] <N>/<N> | ||
| Verifying your keystores: [####################################] <N>/<N> | ||
| Verifying your deposits: [####################################] <N>/<N> |
There was a problem hiding this comment.
If my nitpicking comments got included, need to modify the README.md a bit too.
| @@ -26,7 +27,9 @@ def verify_deposit_data_json(filefolder: str) -> bool: | |||
| """ | |||
| with open(filefolder, 'r') as f: | |||
| deposit_json = json.load(f) | |||
| return all([validate_deposit(deposit) for deposit in deposit_json]) | |||
| with click.progressbar(deposit_json, label='Verifying your deposits:\t', | |||
There was a problem hiding this comment.
Suggested change
| with click.progressbar(deposit_json, label='Verifying your deposits:\t', | |
| with click.progressbar(deposit_json, label='Verifying your deposit(s):\t', |
|
I decided to remove the "(s)" everywhere, because I don't expect there to be too many single deposits and even if there are, I don't think it is the end of the world so assume the plural. IMO "(s)" just looks ugly. |
Merged
everhusk
pushed a commit
to earthbitcoin/earth-wallet-cli
that referenced
this pull request
Aug 3, 2023
Progress bars for key generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating many keys, it can be frustrating not knowing how long it takes to generate your keys. This PR helps mitigate this frustration by offering progress bars: